Adding Proper Support for Fonts #2481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what was the old solution? why doesn't it work anymore? |
ping @shefik response? |
| // process include | ||
| self::readfile($contents, $url, $ext); | ||
|
|
||
| if (!is_readable($url)) { |
There was a problem hiding this comment.
Does this check for whether it is a remote url? Can this be done in a cheaper way avoiding file system access?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for page var "font", and correcting error, where @import was not supporting remote URLs.
Example use in a template:
{pageaddvar name='font' value='//fonts.googleapis.com/css?family=Oswald:300,400,700'}Any remote font URL can be used. It does not need to be a Google font. All fonts will be loaded before other stylesheets, since it is required for fonts to always load first for proper styling.