Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauled and improved translation extraction and handling #4064

Merged
merged 91 commits into from Jan 21, 2020
Merged

Conversation

Guite
Copy link
Member

@Guite Guite commented Jan 13, 2020

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #4012
Refs tickets #2425, #4057
License MIT
Changelog updated yes

Description

This PR basically includes the following amendments:

  • Remove JMSTranslationBundle entirely
  • Install and enable php-translation/symfony-bundle instead
  • Configure it's functionality and create two configurations (one for core and one for extensions)
  • Add a new GitHub actions workflow for running the extractor every 2 days and adding missing translations as a pull request
  • Add annotations (@Ignore and @Translate) where needed
  • Remove more unrequired translator calls in form types
  • Move some remaining form creations from controllers into form types
  • Remove unrequired translator calls in flashes
  • Add docs for translator and extractor handling (will be finished in Unify and update translation docs #4057)
  • Utilise the "Edit in Place" functionality
  • Utilise the "WebUI" functionality
  • Change the way we use translation domains (not equal to the bundle name anymore, but a context for translators, like for example mail, messages, navigation, validators and admin)
  • Extend LocaleApi to support lists without and with regions (e.g. de_DE)
  • Centralise locale-related parameters and reuse for different bundles
  • Extend LocaleApi to reflect auto-discovery of new/removed locales in configuration (using new LocaleConfigHelper)
  • Implement dynamic configuration handling for translation settings (required e.g. for web ui) (using new TranslationConfigHelper)
  • Add missing extractor for form type alerts
  • Add missing extractor for form type input groups
  • Add missing extractors for KnpMenuBundle
  • Add missing extractor for JMSI18nRoutingBundle

@craigh
Copy link
Member

craigh commented Jan 15, 2020

please add extraction to travis job when this is ready

@Guite
Copy link
Member Author

Guite commented Jan 15, 2020

please add extraction to travis job when this is ready

I've already setup an independent Github workflow: https://github.com/zikula/core/blob/translation/.github/workflows/update-translations.yml
This is going to create pull requests for new/missing translations.

@zikula zikula deleted a comment from craigh Jan 21, 2020
@zikula zikula deleted a comment from craigh Jan 21, 2020
@Guite Guite changed the title [WIP] Translation | DO NOT MERGE YET Overhauled and improved translation extraction and handling Jan 21, 2020
@Guite Guite merged commit 959de5a into master Jan 21, 2020
@Guite Guite deleted the translation branch January 21, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants