Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support to store images in cache storage. #157

Closed
xiaofan-luan opened this issue Apr 9, 2023 · 3 comments
Closed

[Feature]: Support to store images in cache storage. #157

xiaofan-luan opened this issue Apr 9, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@xiaofan-luan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

For models working on image generation, we can store the result image in cache storage rather than just text.

TODO: support minio cache storage backend and local disk storage backend

Describe the solution you'd like.

No response

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

@fzliu
Copy link
Contributor

fzliu commented Apr 11, 2023

@xiaofan-luan I'll take a stab at this later this week or over this weekend if nobody else beats me to it

@jiaoew1991
Copy link
Contributor

jiaoew1991 commented Apr 14, 2023

@xiaofan-luan I'll take a stab at this later this week or over this weekend if nobody else beats me to it

@fzliu I suggest using opendal as the access layer for storage. It provides a unified interface to access file systems, memory, S3, etc. Although it is written in Rust, it has bindings for various languages especially Python.

https://github.com/apache/incubator-opendal/blob/main/bindings/python/README.md

@SimFG SimFG added the enhancement New feature or request label Apr 14, 2023
@SimFG
Copy link
Collaborator

SimFG commented Apr 24, 2023

The latest version of GPTCache have implemented it, pr: #213. So i will close the issue. @jiaoew1991 But we didn't use the opendal as the access layer for storage. If we need to access more object storage in the future, we will consider using it.

@SimFG SimFG closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants