Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating travis config to build both boxes with packer. #5

Closed
wants to merge 1 commit into from

Conversation

Tzrlk
Copy link

@Tzrlk Tzrlk commented Sep 14, 2015

  • The ATLAS_TOKEN will need to be encrypted using travis
  • I haven't tested the deployment script (I don't know what the packer outputs are).

@zimbatm
Copy link
Member

zimbatm commented Sep 15, 2015

Doesn't atlas support the github integration itself ?

@zimbatm
Copy link
Member

zimbatm commented Sep 15, 2015

Just checked, atlas offers integration but wants full admin rights on public and private repos

@zimbatm
Copy link
Member

zimbatm commented Oct 19, 2015

@Tzrlk sorry for the wait, I am still pondering on what the best approach is.

Right now Atlas only works for the x86_64 arch for some reason so I still have to build the other box by hand anyways and running packer push file.json is not too much of a hassle.

What would be nice is to have PR automatically validate some of the structure of the project like the .json format and make sure the Makefile has been run.

@Tzrlk
Copy link
Author

Tzrlk commented Oct 19, 2015

Does the Atlas integration support building pull requests? That's the main
benefit I see from using travis. It'll actually give you build status
notifications.

On Tue, 20 Oct 2015 at 02:17 zimbatm notifications@github.com wrote:

@Tzrlk https://github.com/Tzrlk sorry for the wait, I am still
pondering on what the best approach is.

Right now Atlas only works for the x86_64 arch for some reason so I still
have to build the other box by hand anyways and running packer push
file.json is not too much of a hassle.

What would be nice is to have PR automatically validate some of the
structure of the project like the .json format and make sure the Makefile
has been run.


Reply to this email directly or view it on GitHub
#5 (comment).

@zimbatm
Copy link
Member

zimbatm commented Oct 20, 2015

Answering with another question: is it possible to run the builds without
uploading the artifacts ? I don't want PRs to replace existing images.

Atlas requires too many permissions that I feel comfortable to attach to my
account.

On Mon, 19 Oct 2015 23:50 Peter Cummuskey notifications@github.com wrote:

Does the Atlas integration support building pull requests? That's the main
benefit I see from using travis. It'll actually give you build status
notifications.

On Tue, 20 Oct 2015 at 02:17 zimbatm notifications@github.com wrote:

@Tzrlk https://github.com/Tzrlk sorry for the wait, I am still
pondering on what the best approach is.

Right now Atlas only works for the x86_64 arch for some reason so I still
have to build the other box by hand anyways and running packer push
file.json is not too much of a hassle.

What would be nice is to have PR automatically validate some of the
structure of the project like the .json format and make sure the Makefile
has been run.


Reply to this email directly or view it on GitHub
#5 (comment).


Reply to this email directly or view it on GitHub
#5 (comment).

@Tzrlk
Copy link
Author

Tzrlk commented Oct 20, 2015

Yeah, that's the idea. It only deploys on tags.

On Tue, 20 Oct 2015 at 23:01 zimbatm notifications@github.com wrote:

Answering with another question: is it possible to run the builds without
uploading the artifacts ? I don't want PRs to replace existing images.

Atlas requires too many permissions that I feel comfortable to attach to my
account.

On Mon, 19 Oct 2015 23:50 Peter Cummuskey notifications@github.com
wrote:

Does the Atlas integration support building pull requests? That's the
main
benefit I see from using travis. It'll actually give you build status
notifications.

On Tue, 20 Oct 2015 at 02:17 zimbatm notifications@github.com wrote:

@Tzrlk https://github.com/Tzrlk sorry for the wait, I am still
pondering on what the best approach is.

Right now Atlas only works for the x86_64 arch for some reason so I
still
have to build the other box by hand anyways and running packer push
file.json is not too much of a hassle.

What would be nice is to have PR automatically validate some of the
structure of the project like the .json format and make sure the
Makefile
has been run.


Reply to this email directly or view it on GitHub
#5 (comment).


Reply to this email directly or view it on GitHub
#5 (comment).


Reply to this email directly or view it on GitHub
#5 (comment).

@zimbatm
Copy link
Member

zimbatm commented Sep 6, 2016

Hey, sorry for not keeping-up on that.

I just setup the Atlas integration so Travis is not needed. I'll go ahead and close the issue but feel free to comment and I'll re-open it if you think this should still be tackled.

@zimbatm zimbatm closed this Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants