Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.1 #43

Merged
merged 3 commits into from
Sep 9, 2017
Merged

v1.1.1 #43

merged 3 commits into from
Sep 9, 2017

Conversation

bezoerb
Copy link
Collaborator

@bezoerb bezoerb commented Sep 7, 2017

Need a review to push package.json bumpt into master

@olets
Copy link
Collaborator

olets commented Sep 8, 2017

Cool!

Can you split 487b35d into two commits, one for atpl with a commit message referencing #16, and one for bumping the replace-ext dependency?

It'd be nice to ship the replace-ext update. The replace-ext commit could also bump gulp-twig (1.1.1), or the replace-ext commit could be moved before the 1.1.0 bump.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ☺

@ghost
Copy link

ghost commented Sep 8, 2017

@olets is correct, split into 2 commits would be much better.

@bezoerb bezoerb changed the title v1.1.0 v1.1.1 Sep 8, 2017
@bezoerb
Copy link
Collaborator Author

bezoerb commented Sep 8, 2017

done ;)
Feel free to merge & tag if there's nothing left to optimize.
I can publish to npm afterwards

@olets olets merged commit 004763d into master Sep 9, 2017
@olets olets deleted the release-v1.1.0 branch September 9, 2017 20:28
@bezoerb
Copy link
Collaborator Author

bezoerb commented Sep 10, 2017

npm bumped :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants