Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ruff excluded #578

Open
PythonFZ opened this issue Jan 23, 2023 · 3 comments · Fixed by #580
Open

update ruff excluded #578

PythonFZ opened this issue Jan 23, 2023 · 3 comments · Fixed by #580

Comments

@PythonFZ
Copy link
Member

After #567 we excluded as many as possible of ruffs errors. We should slowly bring them back.

MDSuite/pyproject.toml

Lines 13 to 20 in 0b85016

extend-ignore = [
"D213", "D203", "D401",
"D100", "D101", "D102", "D103", "D105", "D107",
"D200", "D202", "D205", "D207", "D212",
"D400", "D404", "D405", "D406", "D407", "D409", "D410", "D411", "D412", "D413", "D414", "D415", "D416", "D417",
"C400", "C408", "C410", "C416",
"C901",
"N802", "N803", "N806", "N818"

@SamTov
Copy link
Member

SamTov commented Jan 27, 2023

Is this not done with the closing of the PR?

@SamTov
Copy link
Member

SamTov commented Jan 27, 2023

I'm finding that ruff ignore commands are inconsistent at best.

There is a case where if you exclude D401 it reports an error saying D401 does not exist. If you remove it, you get new ruff failures for D400 and D415. Once these are added back, it passes but fails in our CI due to error D401. Once D400 and D415 are in the ignore file, then one can ignore D401 without an error.

I guess we need to correct all possible errors before seeing what the issue is but sometimes it throws and error for something that doesn't exist, for example a missing full stop that is not missing.

@PythonFZ
Copy link
Member Author

PythonFZ commented Jan 31, 2023

I think some of the errors might be related to inconsistent versions. I tried to fix some in #582 but eventually this will be resolved with #528

I agree, that not all ruff checks are necessary, but I think ending up with a small list of deliberately selected exclusions would be the ideal case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants