Zingchart-React compatibility with React 18+ #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prefer ESM of ES - Removed sourcemaps - Updated unit tests
- Use `npm ci` to run a clean installation
- Updated packages - Remove of unused scripts - Updated Zingchart version number
Created a small demo app to test future changes - Moved the ZingChart component to `src/lib`
- Do not commit generated output files
Bramikke
changed the title
Bramikke
changed the title
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
jeanettephung
approved these changes
Dec 7, 2023
|
@jeanettephung I see the the test-workflow is failing. I assume it should be fixed by updating the Node version. (eg. 17.5.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility update for React 18
This update addresses the compatibility issues with React 18 and future upcoming versions.
A small demo project has been added to test future changes immediately.
The Zingchart-react wrapper has been moved to
/src/lib.Changelog
src/libdist/files