Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking phase matches from the same dataset #54

Closed
doku opened this issue Nov 29, 2021 · 2 comments
Closed

Linking phase matches from the same dataset #54

doku opened this issue Nov 29, 2021 · 2 comments
Assignees
Milestone

Comments

@doku
Copy link

doku commented Nov 29, 2021

During Linking phase, matches and comparison is done on the rows from the same dataset.

** To Reproduce **

  1. Run findTrainingData, label, train, and link phase.
  2. During label phase, rows from the same dataset is displayed for labeling.
  3. The resulting output have matching pairs with the same z_source.

** Expected behavior **
I'm expecting during labeling phase to only show rows from different z_source. And I'm expecting output to also only have pairs with different z_source.

@sonalgoyal
Copy link
Member

Thanks for reporting this issue Jason @doku. We purposely keep the training data and labeling like this so that it can find samples better. Can you please let me know why this is a concern for you? Is it not showing enough pairs across the sources?

I have fixed the issue for linking. Can you please take the latest code and tell me if this is working fine for you?

@sonalgoyal sonalgoyal self-assigned this Dec 7, 2021
@sonalgoyal sonalgoyal added this to the 0.4 milestone Dec 15, 2021
@sonalgoyal
Copy link
Member

fixed through #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants