Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number comparison implementation #51

Closed
clearloop opened this issue Jul 21, 2023 · 0 comments · Fixed by #63
Closed

Fix number comparison implementation #51

clearloop opened this issue Jul 21, 2023 · 0 comments · Fixed by #63
Labels
bug Something isn't working
Milestone
v0.1.0 - MVP

Comments

@clearloop
Copy link
Member

Which library is the bug in?

codegen

Which version of are you on?

0.0.0

Operating System

None

Describe the bug

  1. The number comparison implementation will not work for different types or signed-integers and float types
  2. the ge and le serie of operators are pointing to gt and lt incorrectly

logs

Please include the logs as well if relevant.
@clearloop clearloop added the bug Something isn't working label Jul 21, 2023
@clearloop clearloop added this to the v0.2.0 - ERC20 milestone Jul 21, 2023
@clearloop clearloop modified the milestones: v0.2.0 - ERC20, v0.1.0 - MVP Aug 3, 2023
This was referenced Aug 3, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.1.0 - MVP
Development

Successfully merging a pull request may close this issue.

fix(codegen): (br_)if conditions and comparison zink-lang/zink
1 participant
@clearloop