Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os.tmpdir() instead of .tmp #37

Closed
ericclemmons opened this issue Jul 22, 2016 · 3 comments
Closed

Use os.tmpdir() instead of .tmp #37

ericclemmons opened this issue Jul 22, 2016 · 3 comments

Comments

@ericclemmons
Copy link

(I can send a PR for this if you'd like.)

Until #25 lands (which I think is great, but complicated), rather than .tmp/, we could use require("os").tmpdir(), which does what it says :)

@ericclemmons
Copy link
Author

Or, alternatively, give preference to output.path, if it exists.

@zinserjan
Copy link
Owner

Hmmm, I think that it's not worth it to invest time on this.

Also, when we move the tmp directory to systems tmp dir, this could lead to problems with webpack's externals config. Node's require algorithm will no longer find node_modules.

@ericclemmons
Copy link
Author

Makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants