Closes #4 sbt plugin to build native image #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@alterationx10 Thank you! Can you resolve the conflicts and also document the usage and state of this plug-in and additional work to do? |
|
Absolutely! I'll try to get that in later today. |
|
Awesome, thank you! |
|
@jdegoes The conflict seems to have resolved itself 🎉 I've done a little bit of naming/cleaning/refactoring, and added a Please let me know if there's anything more to add to help make it clearer! |
jdegoes
approved these changes
Nov 24, 2020
|
@alterationx10 Awesome, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still lots to clean up with this, but wanted to start a PR to get some feedback for improving.
I'm thinking it would be best to publish a separate artifact for the SBT plugin, that users could add to their project. I didn't have luck easily depending on is as a separate project, especially with it depending on a particular version of Scala. If that's the case, maybe (eventually) put it in it's own repo?
This mainly just calls from org.scalameta's sbt-native-image for the real work, and has a couple of settings that map 1:1 to that plugins settings. Would we want to do that, or rely on setting the "upstream" native image options?