Scala 3 Support #62
Merged
Scala 3 Support #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbrown25
requested review from
amitksingh1490,
dinojohn,
fenilkanjani,
pranjalnadhani,
ravisharnagat,
ShrutiVerma97 and
tusharmath
as code owners
brbrown25
commented
Mar 22, 2021
brbrown25
force-pushed
the
feat/ISSUE-59
branch
3 times, most recently
from
ecaa805
to
aadf9d2
Compare
|
tusharmath
requested changes
Mar 23, 2021
zio-http/src/main/scala/zhttp/service/server/ServerChannelFactory.scala
Outdated
Show resolved
Hide resolved
zio-http/src/main/scala/zhttp/service/server/ServerChannelFactory.scala
Outdated
Show resolved
Hide resolved
zio-http/src/main/scala/zhttp/service/server/ServerChannelFactory.scala
Outdated
Show resolved
Hide resolved
tusharmath
reviewed
Mar 23, 2021
tusharmath
reviewed
Mar 23, 2021
|
@tusharmath I'll be working through the failed build and instance stuff today, should hopefully have an update non draft pr later today or tomorrow! |
brbrown25
force-pushed
the
feat/ISSUE-59
branch
2 times, most recently
from
9ec0cba
to
6ce0239
Compare
|
@tusharmath I got it successfully cross compiling. I need to change from ChannelFactory -> Channel instead. I also made the change for the |
tusharmath
reviewed
Mar 25, 2021
tusharmath
reviewed
Mar 25, 2021
brbrown25
force-pushed
the
feat/ISSUE-59
branch
from
6ce0239
to
2a259fe
Compare
|
This was amazing! Thanks a ton @brbrown25 ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.