Add @mockable support #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ZStream mocks generation should be fixed in zio/zio#3895, ZSink generation still doesn't work in zio's @mockable macro so I didn't implement it in the plugin |
timaliberdov
force-pushed
the
mockable-support
branch
from
7a7296f
to
b3c4d0e
Compare
hmemcpy
reviewed
Jul 12, 2020
| clause <- method.paramClauses.clauses | ||
| param <- clause.parameters | ||
| paramType <- param.paramType | ||
| presentation = presentationString(paramType.typeElement) |
There was a problem hiding this comment.
presentationString is removed in 2020.2. Any other way to do this?
There was a problem hiding this comment.
Hmm.. I'll look for an alternative. Note to self: same for accessible macro
There was a problem hiding this comment.
Yeah, I noticed it there too!
Thanks!
There was a problem hiding this comment.
Borrowed rendering related code from 2020.1 and 2020.2 versions of Scala plugin 😅
We'll need some refactoring once 2020.2 is out of beta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28