Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built jar for Scala 3 is missing .sjsir files #490

Closed
laogao opened this issue Nov 21, 2021 · 2 comments · Fixed by #491
Closed

Built jar for Scala 3 is missing .sjsir files #490

laogao opened this issue Nov 21, 2021 · 2 comments · Fixed by #491

Comments

@laogao
Copy link
Contributor

laogao commented Nov 21, 2021

The built jar for Scala 3 is missing .sjsir files required (expected) by projects with Scala.js.
@laogao
Copy link
Contributor Author

laogao commented Nov 21, 2021

Found a fix which involves a minor change to project/BuildHelper.scala. PR on the way.

laogao added a commit to laogao/zio-json that referenced this issue Nov 21, 2021
@laogao
Fixed zio#490 - Included the missing .sjsir artifacts
3c32be4
@laogao laogao mentioned this issue Nov 21, 2021
Merged
fsvehla pushed a commit that referenced this issue Nov 22, 2021
@laogao
Fixed #490 - Included the missing .sjsir artifacts (#491)
b731794
@DamianReeves
Copy link

Is it possible to get a release for this, I'm being blocked by this issue as well.

fsvehla pushed a commit that referenced this issue Nov 26, 2021
@laogao
Fixes #494 conflicting cross-version suffixes (#495)
61e5bc3 
* Fixed #490 - Included the missing .sjsir artifacts

* fixes #494 conflicting cross-version suffixes
fsvehla pushed a commit that referenced this issue Nov 28, 2021
@laogao
Fixes #496: Referring to non-existent class magnolia... (#497)
c527099 
* Fixed #490 - Included the missing .sjsir artifacts

* fixes #494 conflicting cross-version suffixes

* Fixes #496: Referring to non-existent class magnolia...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #490 - Included the missing .sjsir artifacts laogao/zio-json
2 participants
@laogao @DamianReeves