Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #496: Referring to non-existent class magnolia... #497

Merged
merged 5 commits into from
Nov 28, 2021

Conversation

laogao
Copy link
Contributor

@laogao laogao commented Nov 27, 2021

Fixes #496: Referring to non-existent class magnolia...

@laogao laogao requested a review from a team as a code owner November 27, 2021 09:10
@fsvehla
Copy link
Contributor

fsvehla commented Nov 27, 2021

@laogao Any idea why the CI build would not have picked up on this failure and how we could reproduce it?

@laogao
Copy link
Contributor Author

laogao commented Nov 27, 2021

@fsvehla This error only shows up in Scala.js projects that use zio-json, not when building zio-json itself. The problem is with the transitive dependency on magnolia-core version 2.0.0-M9. Since build.sbt used %% instead of %%%, the jar file it found was not the one with .sjsir. When compiling for Scala.js the compiler would complain about missing magnolia classes.

@DamianReeves
Copy link

Thanks so much for this, I've been banging my head against this issue for a couple of weeks but wasn't skilled enough with Scala.js to be sure it wasn't a stupid user error.

@fsvehla fsvehla merged commit c527099 into zio:develop Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Scala.js project during fastLinkJS: Referring to non-existent class magnolia.*
3 participants