Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1003: correct indent of seq of objects #1004

Conversation

fanf
Copy link
Contributor

@fanf fanf commented Aug 22, 2023

This PR addresses #1003 as shown in the added test. The problem was just linked to the default value of IndentWithIndicator.

To avoid having an other case where an user can't change a non-exposed config parameter of SnakeYaml, I also added in YamlOption the way to get a new base DumpsterOptions so that one can always pre-set it with what is needed.

@fanf fanf requested a review from a team as a code owner August 22, 2023 17:08
Copy link
Contributor

@vigoo vigoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go if CI passes

@fsvehla fsvehla merged commit 48b561d into zio:series/2.x Aug 23, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants