-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin module #94
Closed
Closed
Admin module #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.sbt # src/test/scala/zio/kafka/client/ConsumerTest.scala # src/test/scala/zio/kafka/client/ConsumerTest2.scala # src/test/scala/zio/kafka/client/KafkaTestUtils.scala # src/test/scala/zio/kafka/client/ProducerTest.scala
@TimPigden This one is pending on a next ZIO release, right? |
Yes - I was expecting it all rather sooner. So I updated all the tests to
use a whole bunch of Adam's new goodness. But it's also complicated by the
issue of when confluent update to a 5.4 so the embedded-kafka can be
updated to the one that is compatible with my kafka-registry project. If we
get an RC18 first, I'll probably do a fork that omits 2.13 support and
stays with kafka 2.3.1 until such a time as I can bring them together again
If you need it urgently you can refork my fork and just keep the admin
management bits but you'll need to backport the tests to rc17
…On Wed, 1 Jan 2020 at 13:12, svroonland ***@***.***> wrote:
@TimPigden <https://github.com/TimPigden> This one is pending on a next
ZIO release, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#94?email_source=notifications&email_token=AAJWHJ56LHVWRPZSR6I6ZVTQ3SJFPA5CNFSM4JTVYYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5E46I#issuecomment-570052217>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJWHJZ6CIPXEUKW3INEK5LQ3SJFPANCNFSM4JTVYYAQ>
.
--
Tim Pigden
Optrak Distribution Software Limited
+44 (0)1992 517100
http://www.linkedin.com/in/timpigden
http://optrak.com
Optrak Distribution Software Ltd is a limited company registered in England
and Wales.
Company Registration No. 2327613 Registered Offices: Suite 6,The Maltings,
Hoe Lane, Ware, SG12 9LR England
This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the author and do not necessarily
represent those of Optrak Distribution Software Ltd. If you are not the
intended recipient of this email, you must neither take any action based
upon its contents, nor copy or show it to anyone. Please contact the sender
if you believe you have received this email in error.
|
The master branch is now using the snapshot version of ZIO, with the new environment encodings. If you have the time to rebase this and refactor to use the new encoding, feel free to re-open :-) Thank you for the time already put into this branch! |
I'll update all my stuff once RC18 is out
…On Sun, 16 Feb 2020 at 10:26, Itamar Ravid ***@***.***> wrote:
The master branch is now using the snapshot version of ZIO, with the new
environment encodings. If you have the time to rebase this and refactor to
use the new encoding, feel free to re-open :-) Thank you for the time
already put into this branch!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#94?email_source=notifications&email_token=AAJWHJY3JSG6I743XCRZCJ3RDEIG7A5CNFSM4JTVYYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4C3SQ#issuecomment-586689994>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJWHJYP5B2E5RI3SBG2DY3RDEIG7ANCNFSM4JTVYYAQ>
.
--
Tim Pigden
Optrak Distribution Software Limited
+44 (0)1992 517100
http://www.linkedin.com/in/timpigden
http://optrak.com
Optrak Distribution Software Ltd is a limited company registered in England
and Wales.
Company Registration No. 2327613 Registered Offices: Suite 6,The Maltings,
Hoe Lane, Ware, SG12 9LR England
This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the author and do not necessarily
represent those of Optrak Distribution Software Ltd. If you are not the
intended recipient of this email, you must neither take any action based
upon its contents, nor copy or show it to anyone. Please contact the sender
if you believe you have received this email in error.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #93
Added module KafkaAdmin. Rearranged code slightly. Added small section to readme.md to mention it.