Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileOutputStream in LogWriter needs to be opened in append mode. #372

Closed
deusaquilus opened this issue Nov 15, 2021 · 1 comment
Closed

FileOutputStream in LogWriter needs to be opened in append mode. #372

deusaquilus opened this issue Nov 15, 2021 · 1 comment
Assignees
@pshemass

Comments

@deusaquilus
Copy link

In LogWriter, need to change this:

val output = new OutputStreamWriter(new FileOutputStream(destination.toFile), charset)

To this:

val output = new OutputStreamWriter(new FileOutputStream(destination.toFile, true), charset)

Otherwise all file streams opened by the writer will override previous files.
@deusaquilus deusaquilus mentioned this issue Nov 15, 2021
Merged
5 tasks
@pshemass
Copy link
Collaborator

Thanks Alex for reporting that. I will work on that.

@pshemass pshemass self-assigned this Nov 17, 2021
pshemass added a commit to pshemass/zio-logging that referenced this issue Nov 19, 2021
@pshemass
zio#372 append in log writer
152a8fc
pshemass added a commit that referenced this issue Nov 19, 2021
@pshemass
#372 append in log writer (#373)
8a76444
@deusaquilus deusaquilus mentioned this issue Dec 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pshemass pshemass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deusaquilus @pshemass