Scala Native support #397
Merged
Scala Native support #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Scala Native. There seem to be a few bugs:
start()of aProcessBuilderdo not throw exceptions. It seems to create an "empty" process. We can't do anything about this because it is impossible to differentiate a malformed empty process from a real process that seems empty.bash. There is a workaround for this.Sometimes, when using ZStreams as standard input, it's impossible to read from the standard output of a process. It's fine when using a Java
InputStreaminstead. I don't know if it is theProcessthat blocks standard output or if it's theZStreamthat is not sending anything. After closing the standard input, nothing has been sent. It doesn't work either when a ZStream is transformed into an InputStream. I don't know the cause of this bug.So, as long as non-existent commands are not executed and an
InputStreamis used instead ofZStreamswhen there are problems, the rest is completely functional.The first two bugs should be easy to solve within Scala Native.
/claim #4