Optimize execution of datasource-backed ZQueries #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the method which is responsible for partitioning a collection of
ZQuery. There are 2 notable changes in this PR:Continue.GetWith the above, we see ~30% improvement in throughput across the
FromRequestBenchmarksuiteNote that in order to make things a bit safer, I also added the
Modetype-alias and an assertion for a method that the Mode cannot be Parallel. In order to remove the runtime overhead of the assertion, I adopted a similar approach to ZIO where the assertion disappears in the published artifacts