-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cassandra-alpakka #2365
cassandra-alpakka #2365
Conversation
Hey @justcoon. I think we should take out the batching implementation since it's just a sequence of individual actions (just change the function to fail and say it's not supported). At some point we are going to want to implement actual cassandra native-batching in all the contexts but I don't know what that's supposed to look like yet. |
I assume you mean in general other CassandraContext-s got this function, so personally I think it will be better, if this context will also support that if implementation of batching will be changed later, it will have to be changed also in other CassandraContext-s |
Hello @deusaquilus, if I do def executeBatchAction(
groups: List[BatchGroup]
)(info: ExecutionInfo, dc: Runner)(implicit executionContext: ExecutionContext): Result[RunBatchActionResult] = {
Future.failed(new UnsupportedOperationException("Batch action is not supported"))
} current tests (which was made in similar way, like in quill-cassandra module) will also fail
of course, it is expected ..., (test will have to be also fixed with this change). Please, can you confirm, that now you prefer to have the operation as unsupported? Or we will support that like in other CassandraContext-s. Thank you |
If the others already do that you can leave it. This looks complete. |
def executeBatchAction( | ||
groups: List[BatchGroup] | ||
)(info: ExecutionInfo, dc: Runner)(implicit executionContext: ExecutionContext): Result[RunBatchActionResult] = { | ||
Future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the batching implementation is just sequencing a single operation I don't think it's worth implementing. I think Cassandra supports batching natively which we should try to use sometime in the future.
import io.getquill.context.cassandra.udt.UdtSpec | ||
import io.getquill.Udt | ||
|
||
class UdtEncodingSessionContextSpec extends UdtSpec with CassandraAlpakkaSpec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see that this supports UDTs!
Thanks for the contribution @justcoon! Let me know if you're interested in also adding this into ProtoQuill. |
Problem
Context with alpakka cassandra session
https://doc.akka.io/docs/alpakka/current/cassandra.html
Solution
added new module with CassandraAlpakkaContext
Notes
open problems:
Checklist
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers