Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 3.7.13 #2834

Merged
merged 1 commit into from Sep 4, 2023
Merged

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Sep 1, 2023

Fixes #2740

Problem

scalafmt-core 3.1.0 depends on old versions of pprint and geny creating binary compatibility problems with projects using other com.lihaoyi libraries that transitively depend on newer versions of pprint and geny.

Solution

Update scalafmt-core to its latest version which now depends on a shaded fansi library from scalameta.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

This version stops depending on pprint and geny.
This will solve many binary compatibility issues for users using quill
together with the com.lihaoyi libraries.
For example this issue: zio#2740
@lolgab lolgab changed the title Update scalafmt core Update scalafmt-core to 3.7.1 Sep 1, 2023
@lolgab lolgab changed the title Update scalafmt-core to 3.7.1 Update scalafmt-core to 3.7.13 Sep 1, 2023
@guizmaii guizmaii merged commit 685382a into zio:master Sep 4, 2023
19 checks passed
@lolgab lolgab deleted the update-scalafmt-core branch September 4, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use quill if project is using scalatags (scala 3)
2 participants