-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Annotations on all types #125
Comments
I'd like to pick this one up. |
Other than Enum / Case is there anything left to do here? Happy to pick up the rest post hackathon if someone can point out any gaps. |
@alexvanolst Thank you for picking this up!
@thinkharderdev @DamianReeves what do you think? |
Yes! I think we ultimately want to allow annotating any schema. |
Agreed
…On Tue, Nov 2, 2021 at 3:29 PM Dan Harris ***@***.***> wrote:
Yes! I think we ultimately want to allow annotating any schema.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#125 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHJWPQDBTM6XMBSCZ3EZT3UKBC2XANCNFSM5EPBKYKA>
.
|
I've opened a draft PR that gets it compiling with annotations added to the Schema trait. Will probably need some feedback on what the desired behaviour is before it's merge-able since they don't do much right now. |
Closed by #147 |
Annotation support is needed on all types not just on Record.
Currently records support annotations, but it would be useful to also support annotations on all
Schema
types.https://github.com/zio/zio-schema/blob/main/zio-schema/shared/src/main/scala/zio/schema/Schema.scala#L218
The text was updated successfully, but these errors were encountered: