-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to convert to TypedValue #511
Comments
/bounty $200 |
💎 $200 bounty • ZIOSteps to solve:
Additional opportunities:
Thank you for contributing to zio/zio-schema! Add a bounty • Share on socials
|
Looking at zio-schema architecture I don't understand how would it work. Using While |
/attempt #511 Options |
@alankritdabral: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
Going to go ahead and toss my hat in the ring! /attempt #511 Options |
Just dove in to make sure I understand the problem--agree with @andrzejressel on those concerns. Apologies in advance that I'm very new to ZIO, so if anything below doesn't make sense, please let me know! For the purposes of this MR, @jdegoes would it make sense to add additional typing information to The alternatives I thought of were just adding a new, separate Any of these seem like good options for me to implement? |
I think the only way to support this would be to do so using reflection. The class name can be stored (indeed, we already have An alternative might be to allow passing a 'registry' to @tusharmath I know you since moved on but did you have any ideas on how you originally wanted this issue to be solved? |
Hey John! |
Makes sense to me! I can implement that--any list of allowed types I should work off when modifying |
(Additionally, if I wanted to address this in a PR, would I do so under this issue, and would it be in scope for the existing bounty?) |
@foxmoder: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
The bounty is up for grabs! Everyone is welcome to |
I'm new to zio-schema and just wanted to check if the approach taken in #725 makes sense. I naively implemented the registry approach mentioned in #511 (comment). If it does make sense, I'd be happy to gather feedback and finish it. |
If the schema is rebuilt from the AST, it doesn't correctly convert a dynamic value back to a typed value. This is specifically happening with records.
https://scastie.scala-lang.org/TJmOjesrS5KY5ZYHOwJTUg
The text was updated successfully, but these errors were encountered: