Add 'format' function to PostgresModule #184 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasPfeifer
commented
Mar 28, 2021
| @@ -227,6 +227,12 @@ trait PostgresModule extends Jdbc { self => | |||
| FunctionDef[Timestampz, Timestampz](FunctionName("make_timestamptz")) | |||
| val Encode = FunctionDef[(Chunk[Byte], String), String](FunctionName("encode")) | |||
| val Decode = FunctionDef[(String, String), Chunk[Byte]](FunctionName("decode")) | |||
| val Format0 = FunctionDef[String, String](FunctionName("format")) // TODO: varargs | |||
There was a problem hiding this comment.
varargs not available yet (see also 'concat' function)
Is there an open issue for varargs support? otherwise I would open an issue to track this (and might give it a try)
TobiasPfeifer
commented
Mar 28, 2021
| testM("format4") { | ||
| import Expr._ | ||
|
|
||
| val query = select(Format4("Person: %s %s with null-literal %L and non-null-literal %L ", Customers.fName, Customers.lName, "FIXME: NULL", "literal")) from customers |
There was a problem hiding this comment.
couldn't find a solution to specify NULL
tried Option.empty[String] and null.asInstanceOf[String]
There was a problem hiding this comment.
Yeah, Options are not well supported at this point.
|
Thanks for this @TobiasPfeifer ! |
jczuchnowski
approved these changes
Apr 26, 2021
amrkamel
pushed a commit
to amrkamel/zio-sql
that referenced
this pull request
May 26, 2022
…-function Add 'format' function to PostgresModule zio#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements format function in ProstgresModule #184