This repository has been archived by the owner on Jul 16, 2022. It is now read-only.
Have MetricsAspect.adjust call .adjust instead of erroneously calling .set
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgfraser
approved these changes
Oct 22, 2021
atooni
added a commit
that referenced
this pull request
Nov 4, 2021
* Fix compile issues for JS client * Removing code that has migrated to core Refactoring backend implementations * Cleaned up Prometheus and StatsD client * Working on migrating the examples to ZIO 2.0 * Adjusting InstrumentedSample * Calling `gauge.adjust` instead of `.set` (#315) * Update sbt-bloop to 1.4.10 (#313) * Refactoring instrumented example to ZIO 2 * Refactor examples Prometheus server to use uzhttp, more code cleanup after switching to ZIO 2 * Migrated MetricsServer example for developer client to uzHttp * Code migration for all backends completed * Finalizing the first refactoring round to ZIO 2 * Fixing some stuff on the dev client for ZIO 2 * Regressing to ZIO 2.0.0-M4 * Switching the developer client protocol to Json * Use uPickle for now to implement serialization between client and server * Added some documentation, cleaned up some obsolete method calls * Refactor data model, cleanup diagram view * Fix diagramview updates * Just some cleanup * init diagramConfig Co-authored-by: Andreas Gies <andreas@wayofquality.de> * Just some cleanup * Correct MetricMessage Filtering * Make connection url for collecting metrics configurable, Add connect / Disconnect buttons * Cleaning AddDiagram to use a Command updating the state * Moved collected summaries into AppState, so they can be cleaned up on disconnect * Add modifier to make elements visible on conditions, show tables and diagrams only when data is available * Just some cleanup passing information to the views * Move Message Hub to app state as it is condensed to a single var Make WebSocketHandler emit to the command observer Command observer is now responsible for feeding the Message Hub * Just moving some code from DiagramView to Chart View * Tweaking CI to make ZIO2 branch build * Tweaking the CI script * Tweaking the CI script * More CI tweaking * Disable CI ing the docs for zio2 until we actually looked at them * Only compile examples in CI for 2.13 * Tweak build.sbt to remove uzhttp dependency from core Co-authored-by: Igal Tabachnik <hmemcpy@gmail.com> Co-authored-by: Scala Steward <43047562+scala-steward@users.noreply.github.com> Co-authored-by: esteban <esteban.marin@adidas.com>
atooni
added a commit
that referenced
this pull request
Nov 10, 2021
* Fix compile issues for JS client * Removing code that has migrated to core Refactoring backend implementations * Cleaned up Prometheus and StatsD client * Working on migrating the examples to ZIO 2.0 * Adjusting InstrumentedSample * Calling `gauge.adjust` instead of `.set` (#315) * Update sbt-bloop to 1.4.10 (#313) * Refactoring instrumented example to ZIO 2 * Refactor examples Prometheus server to use uzhttp, more code cleanup after switching to ZIO 2 * Migrated MetricsServer example for developer client to uzHttp * Code migration for all backends completed * Finalizing the first refactoring round to ZIO 2 * Fixing some stuff on the dev client for ZIO 2 * Regressing to ZIO 2.0.0-M4 * Switching the developer client protocol to Json * Use uPickle for now to implement serialization between client and server * Added some documentation, cleaned up some obsolete method calls * Refactor data model, cleanup diagram view * Fix diagramview updates * Just some cleanup * init diagramConfig Co-authored-by: Andreas Gies <andreas@wayofquality.de> * Just some cleanup * Correct MetricMessage Filtering * Make connection url for collecting metrics configurable, Add connect / Disconnect buttons * Cleaning AddDiagram to use a Command updating the state * Moved collected summaries into AppState, so they can be cleaned up on disconnect * Add modifier to make elements visible on conditions, show tables and diagrams only when data is available * Just some cleanup passing information to the views * Move Message Hub to app state as it is condensed to a single var Make WebSocketHandler emit to the command observer Command observer is now responsible for feeding the Message Hub * Just moving some code from DiagramView to Chart View * Tweaking CI to make ZIO2 branch build * Tweaking the CI script * Tweaking the CI script * More CI tweaking * Disable CI ing the docs for zio2 until we actually looked at them * Only compile examples in CI for 2.13 * Tweak build.sbt to remove uzhttp dependency from core * adding ui * Slight optimization of chart rendering * Add icon font, upgrade versions * Small changes to the UI / using icons * Colorizing SVG elements & clean up the icon API * Optimise updating of diagrams * first pivot logic * Added the logic to move diagrams up / down * Added some logic to undisplay buttons when they are not required * Pushing diagram configs to the chart view rather than controlling charts from the diagram view. * updated ui * Making ChartViews driven bei config * Finalizing optical changes Co-authored-by: Igal Tabachnik <hmemcpy@gmail.com> Co-authored-by: Scala Steward <43047562+scala-steward@users.noreply.github.com> Co-authored-by: esteban <esteban.marin@adidas.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314