-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added circleci step to compile dotty #1064
Added circleci step to compile dotty #1064
Conversation
@NeQuissimus Linting definitely does a full compile right? Results: https://circleci.com/gh/zio/zio/2814 |
@softinio This doesn't look like it's doing a full compile... it's just checking the source formatting of the files, isn't it? |
@softinio Awesome (Tim may know more about this than me, I just looked at the log, and I know I've used |
Oooohh, that's my bad. I was under the impression that our linting included scalafix! Scalafmt won't trigger a compile, you're right. |
@jdegoes @NeQuissimus This is all ready for you gents to review .... a few notes:
Here is the result https://circleci.com/gh/zio/zio/3202 Hope I didn't miss anything :-) Many thanks. |
@softinio Awesome work. Thank you! |
This resolves #1048