Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added circleci step to compile dotty #1064

Merged
merged 6 commits into from
Jun 24, 2019
Merged

Added circleci step to compile dotty #1064

merged 6 commits into from
Jun 24, 2019

Conversation

softinio
Copy link
Contributor

@softinio softinio commented Jun 22, 2019

This resolves #1048

@softinio softinio added WIP Work in progress build labels Jun 22, 2019
@softinio
Copy link
Contributor Author

@NeQuissimus Linting definitely does a full compile right?

Results: https://circleci.com/gh/zio/zio/2814

@jdegoes
Copy link
Member

jdegoes commented Jun 22, 2019

@softinio This doesn't look like it's doing a full compile... it's just checking the source formatting of the files, isn't it?

@softinio
Copy link
Contributor Author

softinio commented Jun 22, 2019

@jdegoes Agreed thats what I thought but Tim hinted in issue (See #1048) that linting does hence asked him for clarification of what he meant.

Just going to change it to an actual compile to be sure especially since we dont need to lint using dotty

@jdegoes
Copy link
Member

jdegoes commented Jun 22, 2019

@softinio Awesome (Tim may know more about this than me, I just looked at the log, and I know I've used scalafmt on non-compiling code before).

@softinio softinio changed the title Added dotty lint step to compile dotty Added circleci step to compile dotty Jun 22, 2019
@softinio softinio removed the WIP Work in progress label Jun 22, 2019
@softinio softinio mentioned this pull request Jun 22, 2019
@NeQuissimus
Copy link
Member

Oooohh, that's my bad. I was under the impression that our linting included scalafix! Scalafmt won't trigger a compile, you're right.

@softinio softinio added the WIP Work in progress label Jun 23, 2019
@softinio softinio removed the WIP Work in progress label Jun 24, 2019
@softinio
Copy link
Contributor Author

softinio commented Jun 24, 2019

@jdegoes @NeQuissimus This is all ready for you gents to review .... a few notes:

  • Did not include compiling of the interops for dotty in the build as they are imminently being removed from this repo
  • some subprojects that have dotty versions of dependencies not available yet on maven we can't compile so have excluded from build but have opened an issue for it so we can handle when ever dotty versions of those dependencies are available to us see Unable to compile some subprojects due to dotty version of dependencies not being available on maven #1077
  • I did upgrade the version of dotty we are compiling against to 0.16.0-RC3

Here is the result success:

https://circleci.com/gh/zio/zio/3202

Hope I didn't miss anything :-)

Many thanks.

@softinio softinio added the dotty label Jun 24, 2019
@softinio softinio requested a review from jdegoes June 24, 2019 04:21
@NeQuissimus NeQuissimus merged commit 7622ee9 into zio:master Jun 24, 2019
@jdegoes
Copy link
Member

jdegoes commented Jun 24, 2019

@softinio Awesome work. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Circle CI Dotty compilation but not tests
4 participants