ZIO Test: Make Timeout Strategies Test Aspects #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice to be able to pass any aspect rather than just |
ghostdogpr
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1543.
I made
TimeoutStrategy.Warna test aspect and put it inTimeoutVariants.scalathatTestAspect.scalaextends, since there are a lot of implementation specific details for printing the timeout warnings that I didn't want to clutter upTestAspectwith.TimeoutStrategy.ErrorandTimeoutStrategy.Ignorego away since they are redundant withTestAspect.timeoutandTestAspect.identity.I changed the second parameter in
DefaultRunnableSpecto bedefaultTestAspectsand take a list of test aspects to apply to the spec, with a default parameter oftimeoutWarning(60.seconds). So it becomes a little more general if in the future there are other test aspects we want to have as overridable defaults.We were still figuring out the details of the solution we wanted here so happy to take it in another direction but thought it would be good if we had a starting point.