Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checklist: Make everything private that can / should be private #1687 #1751

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Checklist: Make everything private that can / should be private #1687 #1751

merged 3 commits into from
Oct 2, 2019

Conversation

zezutom
Copy link
Contributor

@zezutom zezutom commented Sep 21, 2019

Closes #1687

@zezutom zezutom requested a review from LGLO September 21, 2019 18:09
jdegoes
jdegoes approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the review @LGLO

@jdegoes jdegoes merged commit 060037d into zio:master Oct 2, 2019
@jdegoes
Copy link
Member

jdegoes commented Oct 2, 2019

@zezutom Thanks Tomas!

Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@zezutom @Twizty
Checklist: Make everything private that can / should be private zio#…
c2e2d57 
…1687 (zio#1751)

* ISSUE-1687: Make everything private that can / should be private

* Code review: reverted changes to the public API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

@LGLO LGLO Awaiting requested review from LGLO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checklist: Make everything private that can / should be private
3 participants
@zezutom @jdegoes @LGLO