Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZStream#toInputStream error handling #3700

Merged
merged 1 commit into from
May 25, 2020
Merged

ZStream#toInputStream error handling #3700

merged 1 commit into from
May 25, 2020

Conversation

simpadjo
Copy link
Contributor

@simpadjo simpadjo commented May 25, 2020 •
edited by iravid
Loading

Resolves #3698

@simpadjo simpadjo requested a review from iravid as a code owner May 25, 2020 14:03
iravid
iravid approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. It'd be nice if, as a separate follow up, we could further improve on this by making ZInputStream fully lazy and only pulling the first chunk once someone calls read on the InputStream.

@iravid iravid merged commit 330bb4e into zio:master May 25, 2020
@simpadjo simpadjo deleted the toinputstream-fix branch June 5, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iravid iravid iravid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZStream#toInputStream does not preserve errors
2 participants
@simpadjo @iravid