[Moved to fork] ZIO module for interoperability with related libraries #42

ktonga · 2018-06-14T14:09:17Z

-- Work In Progress --

The idea of this module is to enable code using ZIO IO to interact with other effect types from the Scala ecosystem such as Future and IO from cats-effect. Also define instances for TCs from scalaz-7.2

jdegoes · 2018-06-17T16:49:46Z

Seems like a good idea. 👍

ktonga · 2018-06-19T13:12:05Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+
+import scala.concurrent.Future
+
+object future {


Hey @jdegoes I could you a bit of early feedback on the API while I work on the impl + tests

jdegoes · 2018-06-19T13:12:45Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+
+  val duHastMich: IO[Void, Future[Int]] = duHast.toFuture
+
+  val duHastMichGefragt: Future[Int] = unsafePerformIO(duHastMich)


RAMMSTEIN!!!!!!

jdegoes · 2018-06-19T13:15:35Z

interop/shared/src/main/scala/scalaz/zio/interop/catz.scala

+
+import cats.effect.IO
+
+object catz {


Hopefully this can be mostly grabbed from ioeffect.

Yeah, i'll port it from there. And try to fix a bug that prevents sz IO to be used in fs2 😞

What bug is this?

Not sure, I have to reproduce what fs2 is doing with the Effect instance. Stream.join works with cats IO and monix Task but hangs with ioeffect IO.

jdegoes · 2018-06-19T13:17:30Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+
+}
+
+object SampleUsage {


These examples should be moved, but I'm not sure where.

Sure 😄 It's only to demo the proposed API. I'll add this to the tests and then write some nice examples in the docs

jdegoes · 2018-06-19T13:18:34Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+
+object future {
+
+  implicit class IOObjOps(private val ioObj: IO.type) extends AnyVal {


I like this, if Scala doesn't have a problem with it. Would like to use the same technique in Scalaz 8 to support \/, Maybe.

It doesn't (have a problem). That's the idea of the eager demo, to show that all this compiles and feels super ergonomic IMO.

jdegoes · 2018-06-19T13:18:56Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+object future {
+
+  implicit class IOObjOps(private val ioObj: IO.type) extends AnyVal {
+    def fromFuture[A](ftr: () => Future[A]): IO[Throwable, A] = {


Why not by-name?

Dunno, I don't like it since last time it kept me several nights debugging RTS

jdegoes · 2018-06-19T13:20:13Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+  }
+
+  implicit class IOOps[E, A](private val io: IO[E, A]) extends AnyVal {
+    def toFuture(f: E => Throwable): IO[Void, Future[A]] = io.leftMap(f).toFuture


I think it should have a different name than the toFuture defined in IOThrowableOps. Maybe toFutureE.

Also, it would be customary to make this polymorphic in E2, rather than fixing to Void, although they are of course equivalent.

Noted. I agree.

jdegoes · 2018-06-19T13:22:17Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+  }
+
+  implicit class IOThrowableOps[A](private val io: IO[Throwable, A]) extends AnyVal {
+    def toFuture: IO[Void, Future[A]] = ???


It would be customary to make this polymorphic in E, rather than fixing to Void, although they are of course equivalent.

jdegoes · 2018-06-19T13:24:07Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+
+import scala.concurrent.Future
+
+object future {


Should this be a package object?

What would be the benefit? Just asking.

emilypi · 2018-06-19T16:05:37Z

interop/shared/src/main/scala/scalaz/zio/interop/future.scala

+          case Success(a) => cb(ExitResult.Completed(a))
+          case Failure(t) => cb(ExitResult.Failed(t))
+        }
+      }
  }


Do you want to thunk the Future in this case? on ioeffect I just pushed this PR in - i like the idea of having IO[Void, Future[A]] - then you can lift via point or now.

I saw it, I commented precisely saying i don't like that 🙂

* convert into multi-project build * move some settings to shared

* Backport latest changes from Z8 It includes changes from the following commits affecting the module `effect` in the scalaz/scalaz repository: - scalaz/scalaz@cf6ae80e3 fix bug in par and general code cleanup - scalaz/scalaz@2f6c3dcae code cleanup - scalaz/scalaz@a38e2b634 scalafmt - scalaz/scalaz@d07918ba5 wrap up error model refactoring & update tests - scalaz/scalaz@37c3e92a2 improved docs, function names, and bug fixes - scalaz/scalaz@43e5f0a00 fixes #1665 * fixup! Backport latest changes from Z8

* version bumps * use the same formatting as scalaz8 * fixup! use the same formatting as scalaz8

Include changes from following commits: - scalaz/scalaz@c2f7e6dd8 Add Liskov for `IO.widen` - scalaz/scalaz@3242958cf Use method value. - scalaz/scalaz@456d5ba98 Do not use case classes for IO adt, since the feature is not used. - scalaz/scalaz@043686dcd RTS: use eq/ne when comparing with null. - scalaz/scalaz@de79b92fc RTS Stack: avoid array copy via nesting. removed unused peek(). - scalaz/scalaz@d9ce85e72 remove unused import - scalaz/scalaz@0813ee457 remove try modify variants and add compareAndSet to IORef - scalaz/scalaz@89e337fed code cleanup - scalaz/scalaz@33ec2a23a scalafmt - scalaz/scalaz@01ef0ce21 fix bug

scalaz/scalaz@0358c41bd Modify `SafeApp#run` to return `IO[Void, ExitStatus]` scalaz/scalaz@42e7604dd Include scheduler in app shutdown

* MonadError instances close #49 #46 * cache the common usecase

ktonga · 2018-06-21T13:06:12Z

Closing to reopening it from a branch in my fork #58. If the PR is from a branch in the source repo it publishes snapshots on every push.

More slow tests

ktonga added the WIP Work in progress label Jun 14, 2018

ktonga self-assigned this Jun 14, 2018

This was referenced Jun 17, 2018

Start publishing releases. Deprecate scalaz/ioeffect #50

Closed

IO.widen should apply to the A not the E scalaz/ioeffect#43

Closed

ktonga force-pushed the interop branch from fc916b2 to 3a54a6a Compare June 19, 2018 11:59

ktonga commented Jun 19, 2018

View reviewed changes

jdegoes reviewed Jun 19, 2018

View reviewed changes

emilypi reviewed Jun 19, 2018

View reviewed changes

ktonga and others added 20 commits June 20, 2018 23:19

Create interop sbt module

fa20d5c

Initial draft for future conversions API

5ec4097

Address PR feedback and implement conversions + tests

15f8a57

Initial. TODO: Build, Readme

eb9d8d4

scalafmt

1659974

scalafix automated rules

9d63e3a

no scalac warnings

c1144cf

invariance FTW

d14dd34

single project build (#6)

e0bb9f6

convert into multi-project build (#22)

283e343

* convert into multi-project build * move some settings to shared

Upgrades and consistent formatting (#33)

3759033

* version bumps * use the same formatting as scalaz8 * fixup! use the same formatting as scalaz8

[Backport] Modify SafeApp#run to return IO[Void, ExitStatus] (#38)

73569a6

scalaz/scalaz@0358c41bd Modify `SafeApp#run` to return `IO[Void, ExitStatus]` scalaz/scalaz@42e7604dd Include scheduler in app shutdown

Ported changes in Async from 8.0.x (#36)

12f8ce1

IO.unsafeToFuture / IO.fromFuture

1ef177a

IO.widenError, IO.widen. close #43

5da22cf

bump scalafmt

81e8b68

MonadError, BindRec and Bifunctor instances (#50)

307b0b6

* MonadError instances close #49 #46 * cache the common usecase

Delete stuff

ef2272b

ktonga added 2 commits June 20, 2018 23:29

Port IO Instances from ioeffect project

505144b

Move IO instances to scalaz72 object and make them compile again

5b05b8a

ktonga force-pushed the interop branch from 3080323 to 5b05b8a Compare June 20, 2018 13:45

ktonga changed the title ~~WIP: ZIO module for interoperability with related libraries~~ [Moved to fork] ZIO module for interoperability with related libraries Jun 21, 2018

ktonga closed this Jun 21, 2018

ktonga deleted the interop branch June 21, 2018 13:06

iravid pushed a commit to iravid/zio that referenced this pull request Aug 2, 2020

Merge pull request zio#42 from iravid/more-slow-tests

77d82e6

More slow tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Moved to fork] ZIO module for interoperability with related libraries #42

[Moved to fork] ZIO module for interoperability with related libraries #42

ktonga commented Jun 14, 2018 •

edited

Loading

jdegoes commented Jun 17, 2018

ktonga Jun 19, 2018

jdegoes Jun 19, 2018

jdegoes Jun 19, 2018

ktonga Jun 19, 2018

jdegoes Jun 19, 2018

ktonga Jun 19, 2018

jdegoes Jun 19, 2018

ktonga Jun 19, 2018

jdegoes Jun 19, 2018

ktonga Jun 19, 2018

jdegoes Jun 19, 2018

ktonga Jun 19, 2018

jdegoes Jun 19, 2018

ktonga Jun 19, 2018

jdegoes Jun 19, 2018

jdegoes Jun 19, 2018

ktonga Jun 19, 2018

emilypi Jun 19, 2018 •

edited

Loading

ktonga Jun 19, 2018

ktonga commented Jun 21, 2018


		val duHastMich: IO[Void, Future[Int]] = duHast.toFuture

		val duHastMichGefragt: Future[Int] = unsafePerformIO(duHastMich)


		object future {

		implicit class IOObjOps(private val ioObj: IO.type) extends AnyVal {

[Moved to fork] ZIO module for interoperability with related libraries #42

[Moved to fork] ZIO module for interoperability with related libraries #42

Conversation

ktonga commented Jun 14, 2018 • edited Loading

jdegoes commented Jun 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emilypi Jun 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ktonga commented Jun 21, 2018

ktonga commented Jun 14, 2018 •

edited

Loading

emilypi Jun 19, 2018 •

edited

Loading