Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden TestClock #4248

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Harden TestClock #4248

merged 1 commit into from
Sep 29, 2020

Conversation

adamgfraser
Copy link
Contributor

No description provided.

@adamgfraser
Copy link
Contributor Author

This PR incorporates the TestClock improvements from my previous work and runs tests sequentially on Scala.js to get all tests working pending a more comprehensive solution to the issues with the Executor on Scala.js. In my testing this resolved all flakiness with the TestClock itself. The only flakiness I saw is the test regarding ZManaged inner finalizers, which was already identified as flaky and does not involve the clock, and the issues where there is just no response after ten minutes in the CI builds, which I believe is unrelated.

I think it may make sense to merge a version of this while we finalize the Scala.js changes and investigate the CI to start to improve the stability of our builds.

@jdegoes jdegoes merged commit 1774c8e into zio:master Sep 29, 2020
This was referenced Oct 8, 2020
Closed
Closed
@adamgfraser adamgfraser deleted the testclock branch October 13, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamgfraser @jdegoes