Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build ZIO Test for Scala Native #4260

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Build ZIO Test for Scala Native #4260

merged 1 commit into from
Sep 29, 2020

Conversation

sideeffffect
Copy link
Member

No description provided.

@sideeffffect
Copy link
Member Author

One flaky build that needs restarting, otherwise good 👍

@sideeffffect
Copy link
Member Author

@adamgfraser @mijicd could I humbly ask one of you guys to restart that one red build, please? 🙇

@mijicd
Copy link
Member

mijicd commented Sep 29, 2020

@sideeffffect done :)

@adamgfraser
Copy link
Contributor

@sideeffffect What was the failure you saw and had you merged upstream changes? Want to make sure we are more on top of flagging these build failures as they occur and addressing the underlying causes so we don't get back in the situation of having flakiness in the build.

@sideeffffect
Copy link
Member Author

It was a timeout this time.
Don't worry, no logtrace is lost!
https://app.circleci.com/pipelines/github/zio/zio/9096/workflows/31bf0ebe-a9db-4cea-af57-11138190c6db/jobs/92716

Ha! I branched off of Update izumi-reflect to 1.0.0-M8 (#4254) 93527f2f. I didn't have harden TestClock (#4248) 1774c8e3 🤔 But shouldn't CircleCI test against the PR merge branch anyway?

@adamgfraser
Copy link
Contributor

@sideeffffect I'm pretty sure it doesn't do that.

@sideeffffect
Copy link
Member Author

sideeffffect commented Sep 29, 2020 •
edited
Loading

@adamgfraser 😞 you're right
It uses refs/pull/4260/head, but we need it to use refs/pull/4260/merge 🤔

@adamgfraser adamgfraser merged commit fb2adf2 into zio:master Sep 29, 2020
@sideeffffect sideeffffect deleted the zio-test-native branch September 29, 2020 21:27
@sideeffffect
Copy link
Member Author

this PR deserves the scala-native badge
@adamgfraser 🙏

@sideeffffect sideeffffect mentioned this pull request Oct 6, 2020
Closed
@sideeffffect sideeffffect mentioned this pull request Nov 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgfraser adamgfraser adamgfraser approved these changes

@mijicd mijicd Awaiting requested review from mijicd

@softinio softinio Awaiting requested review from softinio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sideeffffect @mijicd @adamgfraser