Make ZManaged accessible (without macros) #7120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I don't think this change is binary compatible. |
charlescd
force-pushed
the
accessible-managed
branch
from
b8f5355
to
fcd3347
Compare
|
Indeed it's not, sorry about that. I just don't get why mima checks are green for 2.12 and 2.13. |
jdegoes
approved these changes
Nov 23, 2022
|
Just a heads up, this won't make it to |
|
@sideeffffect That's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accessiblemacro generates accessors on members returning eitherZIOorZManaged.In our project, we don't use this macro but the macro-less trait
Accessible. Unfortunately, it currently only works on members returningZIO.This PR aims to extend this trait to support
ZManaged