-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge series/1.x to series/2.x #7853
Merge series/1.x to series/2.x #7853
Conversation
… versions in ZIO 2.0 (zio#6478)
* Update Scala.js and Scala Native to last supporting 2.11 * update Scala versions * update Silencer versions * lower Scala versions
# Conflicts: # .github/workflows/ci.yml # build.sbt # core-tests/shared/src/test/scala/zio/ScheduleSpec.scala # core/shared/src/main/scala/zio/Schedule.scala
@mijicd @adamgfraser Please merge as Merge commit (not Squash commit) 🙏 |
15fa8b3
to
f16d929
Compare
Good to be merged @adamgfraser @mijicd 🎉 |
// Once it's available, this should be merged together with the `js-jvm` variant back to `shared`. | ||
// https://github.com/scala-native/scala-native/pull/3127 | ||
private[zio] trait UpdateRuntimeFlagsWithinPlatformSpecific { | ||
type RuntimeFlagsFunc[A] = Int => A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, do we need to mark it as private[zio]
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if the trait is package private and the only object that extends it is package private there is no need for the members to be package private as well.
Please merge as Merge commit (not Squash commit) 🙏