Add working knownSize implementation to ChunkBuilder instances (Scala 2.13+) #8892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing zio/zio-http#2862 we needed to get the size of a
ChunkBuilder.Byte
and saw this was not yet implemented and returned always the default-1
from the underlyingGrowable
trait implementation.This add the implementation for all current
ChunkBuilders
Scala 2.13+.Scala 2.12 is not supported because the underlying
scala.collection.mutalbe.ArrayBuilder
does not have a suitableknownSize
implementation: https://www.scala-lang.org/api/2.12.9/scala/collection/mutable/ArrayBuilder.html