Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add handling of multi-char delimiters in stream #150

Open
zippy opened this issue May 25, 2016 · 1 comment
Open

add handling of multi-char delimiters in stream #150

zippy opened this issue May 25, 2016 · 1 comment
Assignees
@zippy
Labels
partial
Milestone
Proto Launch

Comments

@zippy
Copy link
Owner

zippy commented May 25, 2016 •
edited
Loading

currently we only handle \n as the new line delimiter. Also need to handle CR-LF...
@zippy zippy self-assigned this May 25, 2016
@zippy zippy added this to the May milestone May 25, 2016
zippy added a commit that referenced this issue May 26, 2016
@zippy
refactored delimiter handling in stream to allow arbitrary delimter #150
ccf1abf
@zippy
Copy link
Owner Author

zippy commented May 26, 2016

ccf1abf adds arbitrary delimiter handling to streams.

Still to do is add this into the LINE_BY_LINE flag check of file streams. It'll work just fine for any delimiter that ends in \n (as does CRLF) but, it doesn't work for the general case.

@zippy zippy added partial and removed in progress labels May 26, 2016
@zippy zippy modified the milestones: Proto Launch, Jun Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zippy zippy

Labels
partial
Projects
None yet
Milestone
Proto Launch
Development

No branches or pull requests
1 participant
@zippy