New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interfaces methods parameters names #346

Closed

Adphi opened this issue Mar 23, 2023 · 1 comment

Adphi commented Mar 23, 2023

It would be very helpful to have the method's parameters names in the interfaces definitions, e.g.

type AuthStorage interface {
	CreateAuthRequest(ctx context.Context, authReq *oidc.AuthRequest, userID string) (op.AuthRequest, error)
	// ...
}

instead of:

type AuthStorage interface {
	CreateAuthRequest(context.Context, *oidc.AuthRequest, string) (AuthRequest, error)
	// ...
}

Collaborator

muhlemmer commented Mar 23, 2023

We agree! We have a similar discussion already open here: #145
We are open for pull requests!

Closing this as duplicate.

muhlemmer closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment