refactor: use struct types for claim related types #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhlemmer
force-pushed
the
concrete-claims-type
branch
from
dda419c
to
c217a72
Compare
Codecov Report
@@ Coverage Diff @@
## next #283 +/- ##
==========================================
+ Coverage 41.74% 46.52% +4.78%
==========================================
Files 83 74 -9
Lines 7254 5567 -1687
==========================================
- Hits 3028 2590 -438
+ Misses 3927 2748 -1179
+ Partials 299 229 -70
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
muhlemmer
force-pushed
the
concrete-claims-type
branch
3 times, most recently
from
a33086e
to
4585640
Compare
|
Created regression tests, based on |
muhlemmer
force-pushed
the
concrete-claims-type
branch
from
7e45b7b
to
0abd772
Compare
|
TODO Write unit tests for functions:
Write unit tests for types (getters, setters):
Write Go doc with references to OpenID / Oauth2 on types:
|
This was referenced Mar 2, 2023
Closed
muhlemmer
force-pushed
the
concrete-claims-type
branch
from
5e4f882
to
cc395ed
Compare
this helps to verify that the same JSON is produced, after these types are refactored.
BREAKING change. The following types are changed from interface to struct type: - AccessTokenClaims - IDTokenClaims - IntrospectionResponse - UserInfo and related types. The following methods of OPStorage now take a pointer to a struct type, instead of an interface: - SetUserinfoFromScopes - SetUserinfoFromToken - SetIntrospectionFromToken The following functions are now generic, so that type-safe extension of Claims is now possible: - op.VerifyIDTokenHint - op.VerifyAccessToken - rp.VerifyTokens - rp.VerifyIDToken
- Changed UserInfoAddress to pointer in UserInfo and IntrospectionResponse. This was needed to make omitempty work correctly. - Copy or merge maps in IntrospectionResponse GetUserInfo and SetUserInfo
- Add get methods for Address fields to handle nil pointers as we used to
muhlemmer
force-pushed
the
concrete-claims-type
branch
from
5cb4f89
to
d41f4b5
Compare
muhlemmer
force-pushed
the
concrete-claims-type
branch
from
dcdbe6f
to
7b613c6
Compare
muhlemmer
force-pushed
the
concrete-claims-type
branch
from
f02c2c5
to
ef5a8a2
Compare
WithIssuedAtMaxAge assigned its value to v.maxAge, which was wrong. This change fixes that by assiging the duration to v.maxAgeIAT.
- IDTokenClaims - IntrospectionResponse - UserInfo
muhlemmer
force-pushed
the
concrete-claims-type
branch
from
4b7db85
to
c7f1319
Compare
muhlemmer
commented
Mar 7, 2023
muhlemmer
commented
Mar 7, 2023
This was referenced Mar 8, 2023
Merged
livio-a
requested changes
Mar 10, 2023
livio-a
approved these changes
Mar 10, 2023
|
🎉 This PR is included in version 2.0.0-next.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
muhlemmer
added a commit
that referenced
this pull request
Mar 21, 2023
JWTTokenRequest.GetIssuedAt() was returning the ExpiresAt field. This change corrects that by returning IssuedAt instead. This bug was introduced in #283
muhlemmer
added a commit
that referenced
this pull request
Mar 21, 2023
JWTTokenRequest.GetIssuedAt() was returning the ExpiresAt field. This change corrects that by returning IssuedAt instead. This bug was introduced in #283
muhlemmer
added a commit
that referenced
this pull request
Mar 21, 2023
JWTTokenRequest.GetIssuedAt() was returning the ExpiresAt field. This change corrects that by returning IssuedAt instead. This bug was introduced in #283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING change.
The following types are changed from interface to struct type:
The following methods of OPStorage now take a pointer to a struct type,
instead of an interface:
The following functions are now generic, so that type-safe extension
of Claims is now possible:
This is still a work in process. Need to create some regression tests and I want to verify if the current approach is what we want.