fix: handle the zero cases for oidc.Time

[muhlemmer]

When Time fields was not set in JSON, the zero value 0, resulted in a non-zero time.Time in conversion. This made verifier checks against a zero (unset) time always pass:

oidc/pkg/oidc/verifier.go

Line 179 in 5a14f8d

if issuedAt.IsZero() {

This bug was most likely introduced in #283 refactorings.

Likewise, passing an empty time to oidc.FromTime now results in a 0 value for the JSON.

[codecov]

Codecov Report

Merging #339 (5a14f8d) into main (62caf5d) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   50.80%   50.94%   +0.13%     
==========================================
  Files          74       74              
  Lines        5623     5638      +15     
==========================================
+ Hits         2857     2872      +15     
  Misses       2506     2506              
  Partials      260      260              

Impacted Files	Coverage Δ
pkg/oidc/token.go	56.47% <100.00%> (+2.43%)	⬆️
pkg/oidc/types.go	91.47% <100.00%> (+0.41%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

🎉 This PR is included in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 3.0.0-next.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀