Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Auth0 updated_at #292

Closed
bennesp opened this issue Feb 27, 2023 · 4 comments · Fixed by #311
Closed

Parse Auth0 updated_at #292

bennesp opened this issue Feb 27, 2023 · 4 comments · Fixed by #311
Assignees
@muhlemmer
Labels
enhancement New feature or request good first issue Good for newcomers released on @next released on @1.13.x released

Comments

@bennesp
Copy link

bennesp commented Feb 27, 2023

Is your feature request related to a problem? Please describe.
Using the client example app with auth0 and profile scope leads to this error:

failed to exchange token: json: cannot unmarshal string into Go struct field .updated_at of type int64

Describe the solution you'd like
Like for aws incognito in this issue, zitadel/oidc could be able to parse also non-compliant fields used in the wild.

Auth0 uses RCF3339. Example of field:

"updated_at": "2021-05-11T21:13:25.566Z"

Describe alternatives you've considered
Removing the profile scope is a workaround.

Additional context

I marked this as a feature since it is a non-complaint implementation of auth0 and not a bug on zitadel/oidc

Related to #137
@bennesp bennesp added the enhancement New feature or request label Feb 27, 2023
@muhlemmer muhlemmer added the good first issue Good for newcomers label Mar 2, 2023
@muhlemmer
Copy link
Collaborator

Thanks for sending the issue and it seems clear. Currently I'm refactoring Claims, including the Time type in #283. I will see if I can squeeze a fix in there or else I'll do it after.

@muhlemmer muhlemmer self-assigned this Mar 6, 2023
muhlemmer added a commit that referenced this issue Mar 6, 2023
@muhlemmer
fix: allow RFC3339 encoded time strings
7264a7c 
Fixes #292
@muhlemmer muhlemmer mentioned this issue Mar 6, 2023
Merged
muhlemmer added a commit that referenced this issue Mar 10, 2023
@muhlemmer
fix: allow RFC3339 encoded time strings
80dbc32 
Fixes #292
muhlemmer added a commit that referenced this issue Mar 10, 2023
@muhlemmer
fix: allow RFC3339 encoded time strings
a3fe782 
Fixes #292
@muhlemmer muhlemmer linked a pull request Mar 10, 2023 that will close this issue
fix: allow RFC3339 encoded time strings #311
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.0-next.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

muhlemmer added a commit that referenced this issue Mar 22, 2023
@muhlemmer
fix: allow RFC3339 encoded time strings
865d637 
Fixes #292
@muhlemmer muhlemmer mentioned this issue Mar 22, 2023
Closed
muhlemmer added a commit that referenced this issue Mar 22, 2023
@muhlemmer
fix: allow RFC3339 encoded time strings
a64b97d 
Fixes #292
@github-actions
Copy link

🎉 This issue has been resolved in version 1.13.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muhlemmer muhlemmer

Labels
enhancement New feature or request good first issue Good for newcomers released on @next released on @1.13.x released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow RFC3339 encoded time strings zitadel/oidc
2 participants
@muhlemmer @bennesp