Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom attributes to saml response #56

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented Aug 9, 2023

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@stebenz stebenz requested a review from livio-a August 9, 2023 15:15
@stebenz stebenz self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #56 (3bdfd7a) into main (cc9378c) will decrease coverage by 0.01%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   47.26%   47.26%   -0.01%     
==========================================
  Files          21       21              
  Lines        1976     1993      +17     
==========================================
+ Hits          934      942       +8     
- Misses        984      993       +9     
  Partials       58       58              
Files Changed Coverage Δ
pkg/provider/login.go 57.57% <0.00%> (ø)
pkg/provider/attributes.go 73.41% <47.05%> (-7.23%) ⬇️
pkg/provider/metadata.go 52.94% <100.00%> (ø)

@stebenz stebenz merged commit afbec8e into main Aug 14, 2023
5 of 6 checks passed
@stebenz stebenz deleted the custom-attributes branch August 14, 2023 08:30
@github-actions
Copy link

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants