Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support stdin for hook #13

Merged
merged 13 commits into from
Apr 7, 2022
Merged

Add support stdin for hook #13

merged 13 commits into from
Apr 7, 2022

Conversation

binsee
Copy link
Contributor

@binsee binsee commented Apr 6, 2022

Fixes #12

@binsee
Copy link
Contributor Author

binsee commented Apr 6, 2022 •
edited
Loading

Demonstrate the effect with a pre-push example:

> git push             
args: [
  "origin",
  "git@github.com:binsee/sidecar.git",
  "refs/heads/test2",
  "65b8bd5bd8e8c889fb8ec6228cfada35164cc423",
  "refs/heads/test2",
  "0000000000000000000000000000000000000000"
]

> git push origin      
args: [
  "origin",
  "git@github.com:binsee/sidecar.git",
  "refs/heads/test2",
  "65b8bd5bd8e8c889fb8ec6228cfada35164cc423",
  "refs/heads/test2",
  "0000000000000000000000000000000000000000"
]

> git push origin test2
args: [
  "origin",
  "git@github.com:binsee/sidecar.git",
  "refs/heads/test2",
  "65b8bd5bd8e8c889fb8ec6228cfada35164cc423",
  "refs/heads/test2",
  "0000000000000000000000000000000000000000"
]

> git push origin :test 
args: [
  "origin",
  "git@github.com:binsee/sidecar.git",
  "(delete)",
  "0000000000000000000000000000000000000000",
  "refs/heads/test",
  "65b8bd5bd8e8c889fb8ec6228cfada35164cc423"
]

> git push origin test2 test3
args: [
  "origin",
  "git@github.com:binsee/sidecar.git",
  "refs/heads/test2",
  "65b8bd5bd8e8c889fb8ec6228cfada35164cc423",
  "refs/heads/test2",
  "0000000000000000000000000000000000000000"
]
Total 0 (delta 0), reused 0 (delta 0)
To github.com:binsee/sidecar.git
 * [new branch]      test2 -> test2
 * [new branch]      test3 -> test3

binsee added a commit to binsee/chatie-git-scripts that referenced this pull request Apr 6, 2022
@binsee
Re-push produces meaningless version when push fails
15cbe86 
Fixes Chatie#19

Need  update git-scripts to new version
link git-script/pr: zixia/git-scripts#13
@binsee binsee mentioned this pull request Apr 6, 2022
Merged
huan
huan requested changes Apr 6, 2022
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you very much for the improvement!

Could you please bump the minor version to an odd version, so that we can merge this PR and publish a new version on NPM?

Appreciate it!

@binsee
Copy link
Contributor Author

binsee commented Apr 6, 2022

done

huan
huan approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much for this PR!

@huan huan merged commit a4c17bf into zixia:master Apr 7, 2022
@binsee binsee deleted the binsee/issue12 branch April 7, 2022 16:05
huan pushed a commit to Chatie/git-scripts that referenced this pull request Apr 8, 2022
@binsee
Fix push hook (#20)
2e11368 
* Re-push produces meaningless version when push fails
Fixes #19

Need  update git-scripts to new version
link git-script/pr: zixia/git-scripts#13

* style:

* ci: fix smoke-test

* 0.6.3

* refactor: Comment out unused code

* 0.6.4

* test: fix test error

* 0.6.5

* ci: 💚 update nodejs version

* 0.6.6

* fix: fix error on old version for git-scripts

* 0.6.7

* fix: 🐛 fix npm bump again

* 0.6.8

* build: ⬆️ update git-scripts to 0.5.3

* 0.6.9

* feat: ✨ suppport multi branch in pre-push

* 0.6.10

* fix:

* 0.6.11

* fix: 💚 fix error in test:pack

* 0.6.12

* chore: ⬆️ upgrade git-scripts to 0.6.0

* 0.7.0

* fix: 🐛 fix read properties error

* 0.7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support stdin for hook
2 participants
@binsee @huan