Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push hook #20

Merged
merged 26 commits into from
Apr 8, 2022
Merged

Fix push hook #20

merged 26 commits into from
Apr 8, 2022

Conversation

binsee
Copy link
Member

@binsee binsee commented Apr 6, 2022

Fixes #19

Need update git-scripts to new version
link git-script/pr: zixia/git-scripts#13

Fixes Chatie#19

Need  update git-scripts to new version
link git-script/pr: zixia/git-scripts#13
@CLAassistant
Copy link

CLAassistant commented Apr 6, 2022

CLA assistant check
All committers have signed the CLA.

@huan
Copy link
Member

huan commented Apr 6, 2022

Please make sure the following requirements have been met for your PR before we can continue reviewing it:

  1. You have signed the CLA by clicking the [CLA | not signed yet] button from the comments.
  2. The PR has passed all the CI tests and turns green. (you can execute all tests locally by running npm test)

@binsee
Copy link
Member Author

binsee commented Apr 6, 2022

Please make sure the following requirements have been met for your PR before we can continue reviewing it:

  1. You have signed the CLA by clicking the [CLA | not signed yet] button from the comments.
  2. The PR has passed all the CI tests and turns green. (you can execute all tests locally by running npm test)
  1. done
  2. The same error will be reported in the main branch
 binsee@bogon  ~/CodeWork/chatie-git-scripts   binsee/issue19  npm run test

> @chatie/git-scripts@0.6.2 test
> npm run lint && npm run test:unit


> @chatie/git-scripts@0.6.2 lint
> npm run lint:es && npm run lint:ts


> @chatie/git-scripts@0.6.2 lint:es
> eslint bin/**/*.ts src/**/*.ts tests/**/*.ts


/Users/binsee/CodeWork/chatie-git-scripts/tests/fixtures/smoke-testing.ts
  0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: tests/fixtures/smoke-testing.ts.
The file must be included in at least one of the projects provided

✖ 1 problem (1 error, 0 warnings)

// ----

 ✘ binsee@bogon  ~/CodeWork/chatie-git-scripts   binsee/issue19  git checkout main    
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

// ----

 binsee@bogon  ~/CodeWork/chatie-git-scripts   main  npm run test     

> @chatie/git-scripts@0.6.2 test
> npm run lint && npm run test:unit


> @chatie/git-scripts@0.6.2 lint
> npm run lint:es && npm run lint:ts


> @chatie/git-scripts@0.6.2 lint:es
> eslint bin/**/*.ts src/**/*.ts tests/**/*.ts


/Users/binsee/CodeWork/chatie-git-scripts/tests/fixtures/smoke-testing.ts
  0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: tests/fixtures/smoke-testing.ts.
The file must be included in at least one of the projects provided

✖ 1 problem (1 error, 0 warnings)

@huan
Copy link
Member

huan commented Apr 6, 2022

Thanks for signing the CLA!

Yes, I see that the main branch is broken too, so we need to figure the problem out or the new version can not be published via the DevOps pipeline.

I'll have a look at it after my talk tomorrow, or it would be great if you can find any clue for the problem and try to fix it.

Thank you very much!

@binsee
Copy link
Member Author

binsee commented Apr 6, 2022

I modified tsconfig and the test has passed, but I don't know if the adjustment is correct, because it is different from the configuration of other projects.

@binsee
Copy link
Member Author

binsee commented Apr 7, 2022

Now run git push continuously, no more bump versions

@binsee
Copy link
Member Author

binsee commented Apr 7, 2022

Waiting for zixia/git-scripts#13 to merge, and run CI again

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the minor version so that we can merge and publish it.

Thank you very much!

@binsee
Copy link
Member Author

binsee commented Apr 8, 2022

Please bump the minor version so that we can merge and publish it.

Thank you very much!

done

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much for the improving!

@huan huan merged commit 2e11368 into Chatie:main Apr 8, 2022
@binsee binsee deleted the binsee/issue19 branch April 9, 2022 12:56
@binsee
Copy link
Member Author

binsee commented Apr 9, 2022

@huan After this pr was merged, no new npm package was automatically released.

@huan
Copy link
Member

huan commented Apr 9, 2022

I have just published the new version manually. This repo has not configured the CI/CD so it has not been published automatically.

Please let me know if it works as expected, thanks for mentioning me!

@binsee
Copy link
Member Author

binsee commented Apr 9, 2022

@huan There is an error in the packaging process, the dist folder is missing, so it cannot be used correctly.

@huan
Copy link
Member

huan commented Apr 9, 2022

Sorry for that, I have re-published it as 0.7.2, please try the new version.

@binsee
Copy link
Member Author

binsee commented Apr 9, 2022

Update:

It is a local cache problem, which has been solved


I don't know why the README page for @chatie/git-scripts has no content.

https://www.npmjs.com/package/@chatie/git-scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-push produces meaningless version when push fails
3 participants