Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is there no bias in the output of GCN layer and why there is linear layer before softmax implementation? #12

Closed
utkarsh0902311047 opened this issue Sep 5, 2023 · 1 comment

Comments

@utkarsh0902311047
Copy link

Hi,

  1. I was reading the Thomas N. Kipf pytorch implementation of GCN [https://github.com/tkipf/pygcn/blob/master/pygcn/layers.py]. If I understand correctly, he adds bias to every GCN layer output [line 35].
    Why is it so? Is it required to be done in Numpy implementation, too?
  2. Also, there is no linear layer before the softmax layer. Why does the numpy implementation have a linear layer before the softmax implementation in the softmax_layer function?

Please help
Thank you

@zjost
Copy link
Owner

zjost commented Sep 5, 2023

All of these permutations you're describing are sensible options, and I'm not aware of any good reason to decide one way vs the other, aside from checking empirically what works the best. It will also probably depend on the data.

@zjost zjost closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants