Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: make sure to output last SNP count for each sample #18

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

boris-dimitrov
Copy link
Collaborator

@boris-dimitrov boris-dimitrov commented Aug 16, 2019

Tested on sample SRS077454_1.fastq -- after the fix we get one more SNP, 10464412440730 count 1.

@boris-dimitrov boris-dimitrov changed the title bugfix: make sure to output last kmer count for each sample bugfix: make sure to output last SNP count for each sample Aug 17, 2019
@boris-dimitrov boris-dimitrov force-pushed the boris/fix_known_bug_with_last_snp branch from 5a74959 to c5195dc Compare August 17, 2019 01:52
Copy link
Owner

@zjshi zjshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks great, please go ahead to make the merge!

Tested on sample SRS077454_1.fastq -- after the fix we get one more SNP, 10464412440730 count 1.
@boris-dimitrov boris-dimitrov force-pushed the boris/fix_known_bug_with_last_snp branch from 2e6d937 to b7ed74d Compare September 3, 2019 22:26
@boris-dimitrov boris-dimitrov changed the base branch from boris/untabify to master September 3, 2019 22:28
@boris-dimitrov boris-dimitrov merged commit b80fee9 into master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants