Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme typo #39

Closed
UnkwUsr opened this issue Feb 10, 2022 · 10 comments · Fixed by #40
Closed

readme typo #39

UnkwUsr opened this issue Feb 10, 2022 · 10 comments · Fixed by #40

Comments

@UnkwUsr
Copy link

UnkwUsr commented Feb 10, 2022

In Installation section:
https://github.com/mickael-menu/zk-nvim/blob/b13a191fbbfe427d1aadaf41419520c43abee141/README.md?plain=1#L16-L19

I'm sorry, but this would not work, as " is actually a comment in vimscript. Should be '.

UPD: moreover, there should be custom branch setting:

Plug 'mickael-menu/zk-nvim', { 'branch': 'main' }

UPD2: latest version of vim-plug (0.11.0) have no need in custom branch setting.

@eric-hansen
Copy link
Collaborator

" is only a comment if it's the first character of the line. In this context it's correctly the start of a string.

@UnkwUsr
Copy link
Author

UnkwUsr commented Feb 10, 2022

@eric-hansen Hmmmm... But this does not work for me:

line   18:
E471: Argument required: Plug

Can you test please, if you use vim-plug?

@eric-hansen
Copy link
Collaborator

I don't use vim-plug.

Are you using Vim or Neovim?

@UnkwUsr
Copy link
Author

UnkwUsr commented Feb 11, 2022

Neovim v0.6.1

@mickael-menu
Copy link
Member

I tested and I indeed have the same issue using ".

@kabouzeid
Copy link
Collaborator

But it does work with '?

@mickael-menu
Copy link
Member

Yes, this is what I have:

Plug 'mickael-menu/zk-nvim'

Using ", the plugin is simply not visible with :PlugInstall.

@tomtomjhj
Copy link

Plug is defined with -bar attribute (:command-bar), so " is interpreted as a comment marker.

@mickael-menu
Copy link
Member

I'll do the changes, but first @UnkwUsr why do you think { 'branch': 'main' } should be added? It works fine without for me.

@UnkwUsr
Copy link
Author

UnkwUsr commented Feb 13, 2022

Sorry, my bad. I was using old version of vim-plug, so I had errors without setting custom branch. On latest version of vim-plug (0.11.0) it works fine without branch setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants