-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX/UI redesign] Coinjoin Strategy - add default, reorg and redesign #10505
Comments
Love it! |
This is an excellent way to display the tradeoffs of each setting, it easily conceptualizes the affects of each change you can make! The only problem with the exact model in the video is that the default profile blue dot should appear on the bottom edge of the triangle since has the same anon score target (5) as the cost and speed profiles. If the default profile anon score target were higher, (such as 10), then it would match the existing triangle diagram in the video since moving downwards to specialize in privacy or cost matches the corresponding privacy preference tradeoff of reducing the anon score target to 5. |
Yes, though I would argue to slightly increase anonscore by default, so that any user change leads to a different value. Otherwise the user deviates from default, but the behavior does not change at all. |
A higher default anonscore target also allows the "dot" in the middle of the two corners to be selected as compromises between the other extreme preferences: Red/Blue/Yellow primary colors can "glow" when a user selects a setting in the corners and Orange/Green/Purple secondary colors can "glow" when a user selects a setting on the edges. |
Setting a different I think the idea is good, but there are several things that I dislike, so I'm just sharing my opinion as we are invited to do:
I'm playing devil's advocate, but I think that both your idea and your way of presenting and explaining it are really good. |
@turbolay |
thank you all for you input, as stated, every feedback is valuable. we don't want to introduce a new preset/ strategy just it looks better. what we try to achieve is a sort of education. giving the user a "default" profile/ preset/ strategy is something the uneducated user can understand by itself. its a default, its a mix/ balance between privacy, speed and costs. (of course we can take the actual speed strategy values and use it for default, or set default to "Days") the user understands, there is something already to get back to, to a default where, even without understanding, the user trusts us, the team, that the values are in his interests and the best of all worlds. from there the user can go for more privacy, speed or cost presets. but at that point the user needs to understand what will be changed and how this will affect also his previous privacy progress (up, unchanged, down). and for the super advanced user we still offer "custom", where everything is unlocked to do whatever they like. maybe that could be a tradeoff, and that number of presets is enough, I don't think we need more confusion with more presets in-between (the dots on the triangle ;) new Default Speed Cost Privacy |
ACK this: new Default Speed Cost Privacy |
I think the only problem is the strategies themself. I have a very basic rule... whenever we need to introduce something in order to explain something else is a sign that there is a problem and we should rather take a step back instead of going forward. In this case, by taking a step back I mean removing the concept of strategies.
I 100% agree with this. And this is the actual key move... CJ strategies (copied from #10505 (comment)):
If you take a look at this table and compare different profiles: Privacy profile is the exception as it differs drastically from the others. It is still okay not having a separate configuration for it as people who care about privacy don't trust, they verify. They want 100% know what that configuration changes. So I said having a default configuration is a key move, because 95% of the people stick to the default option. Most users will never ever change any setting... My proposal
I didn't get into details in every aspect if needed we can discuss things more deeply. |
There might be more additional settings added in the future which might justify the profile abstraction. But I agree that currently the number of settings is low, and it might be well explained with less abstractions. Decluttering is often the right move. |
i have something to play with, just find your way to "coinjoin settings" » "strategy selection" appreciating feedback as usual :) |
🎨 Figma Flow to play around and leave comments on the canvas (you need a free figma account) Explanation Videowallet_settings_strategy.mov |
This is excellent. |
I like it. One beneficial side effect of changing the default profile to coinjoin in "days" instead of "hours" means that the coordinator can choose more aggressive mining fees during the most expensive part of the day in order to satisfy the needs of speedy users without requiring those high fees from default users. The "Verify words" functionality is in a strange place, but it was already in a strange place before with its own dedicated menu item, so I guess it's better for it to be merged into the configuration menu item. The only adjustments I would make is to the text to make it less scary. Phrases like "your previous privacy progress can be impacted" may lead the user to believe a loss in privacy progress % was caused by a user mistake rather than an adjusted setting. Here are my replacement suggestions for the texts: -Top menu description: "The 'Balance' preset is applied by default. Your existing privacy progress is updated after changing your anonymity score target" |
imo it just needed to be dropped, please see #10539 (comment)
thank you, i like the improvements, and i'm always open to text suggestions :) will incorporate them into my screens. |
Hey guys. I don't know if this issue is still open, but I want to try my hands on this. Even though its been worked on, I am very open to collaborating. |
Hey! This issue is still open, every contribution is very much appreciated. We can't promise that your ideas will be implemented, but we can promise they'll be considered. |
Thanks @turbolay Currently looking through it. Would try my hands on it |
i'm working right now on redesigning the flow "coinjoin strategies" and tackling the following issues with this: #8880, #10404, #9432, #9813
🎨 Figma Prototype
Explanation Video
coinjoin_strategy_default_selection.webm
please give feedback what you think, based on that i'm proceeding to create low to high fidelity designs.
The text was updated successfully, but these errors were encountered: