Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comma copy recovery words #10540

Merged
merged 1 commit into from Apr 24, 2023
Merged

Remove comma copy recovery words #10540

merged 1 commit into from Apr 24, 2023

Conversation

turbolay
Copy link
Collaborator

Having a comma is non-standard; see #10523

I also agree with the other point of #10523:

The recovery words remain in the clipboard, which is risky.

And could make it in a following PR, but I believe that removing the commas shouldn't be controversial at all; hence I prefer to do it in 2 PRs.

@turbolay turbolay requested review from soosr and yahiheb April 21, 2023 01:43
yahiheb
yahiheb approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

kristapsk
kristapsk approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

soosr
soosr approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@soosr soosr merged commit 73e06c2 into zkSNACKs:master Apr 24, 2023
7 checks passed
@molnard molnard mentioned this pull request May 18, 2023
Closed
@molnard molnard mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapsk kristapsk kristapsk approved these changes

@YohDeadfall YohDeadfall YohDeadfall approved these changes

@soosr soosr soosr approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@turbolay @kristapsk @YohDeadfall @soosr @yahiheb