[VDG] Privacy warnings Improved UX

[ichthus1604]

• Implements this definition
• Fades out Privacy Warnings upon mouse hover on suggestions that would clear those respective warnings
• Changes wording of Suggestions and shows both BTC and Fiat amounts
• Fixes [VDG] Change avoidance: Display suggested amount in btc not usd #11030

[MaxHillebrand]

CACK

The merge-base changed after approval.

[soosr]

Something is wrong:

Also please add a transition effect to fading.

[ichthus1604]

@soosr

Something is wrong

Fixed ;)

Also please add a transition effect to fading.

Done ;)

[soosr]

Fade animation can glitch

[Pule08]

hi @ichthus1604
could you please update us about this PR? What is the status?

Thank you!

[ichthus1604]

@soosr Latest commit seems to have fixed the animation glitch.
Can you please test it again?

[ichthus1604]

@Pule08 I just fixed the remaining problems with this PR, if @soosr approves this can be merged.

[MarnixCroes]

cack

the fadeout is nice

tbh I have some doubt if the text reduction is an improvement for normal user. "Full privacy" what does it mean? Yes you could imply what it means by the effect when hovering over it, but it requires some thinking.
(adding a tooltip to the suggestion with previous text "only use private coins", might help?)

nit: for the change avoidance, instead of Send more by X BTC, maybe use Send X BTC more?

[soosr]

tbh I have some doubt if the text reduction is an improvement for normal user. "Full privacy" what does it mean? Yes you could imply what it means by the effect when hovering over it, but it requires some thinking. (adding a tooltip to the suggestion with previous text "only use private coins", might help?)

The thing is it not only will only use private coins but also remove the change, remove the labels and so. A generic tooltip about what is the goal with that suggestion could help though. Add it in a separate PR.

nit: for the change avoidance, instead of Send more by X BTC, maybe use Send X BTC more?

nACK. It was one of the main points to have the USD value at the end of the row so the users could easily notice it without searching.

[yahiheb]

@ichthus1604 What's up with this?

[soosr]

@ichthus1604 We should revive this PR

[ichthus1604]

@soosr this PR is working fine as far as I can tell, after merging latest master

I can't reproduce the animation glitch... maybe it was an Avalonia issue in a previous version?

My only concern is that light theme makes the Flyout look very ugly with current colors:

[soosr]

I can't reproduce the animation glitch... maybe it was an Avalonia issue in a previous version?

Me neither.

My only concern is that light theme makes the Flyout look very ugly with current colors:

Even horrible on master, UI refreshment will fix it.

Two more thing to implement:

• [VDG] Privacy warnings Improved UX #11463 (comment)
• When a warning is faded out, could make the text crossed out too?

[ichthus1604]

@soosr

Two more thing to implement:

#11463 (comment)

Done ;)

When a warning is faded out, could make the text crossed out too?

Done ;)

[soosr]

tACK